search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Multi instance remove checks #131

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

Removed the check in start to prevent people using multiple instances ...

Why?

We're soon going to be supporting multiple instances, so we need to allow people to provide us multiple! ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #131 into feature-multi-instance will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature-multi-instance     #131      +/-   ##
==========================================================
+ Coverage                    88.7%   88.92%   +0.22%     
==========================================================
  Files                          54       54              
  Lines                        3018     3007      -11     
==========================================================
- Hits                         2677     2674       -3     
+ Misses                        341      333       -8
Impacted Files Coverage Δ
Sources/PushNotifications.swift 87% <ø> (+3.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38a7621...e658288. Read the comment docs.