search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Multi instance register device token #137

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

Ensure that if the register device token is received, that all instances that have been started get that change ...

Why?

We need this for multiple instance support ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #137 into feature-multi-instance will decrease coverage by 0.26%. The diff coverage is 96.87%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature-multi-instance     #137      +/-   ##
==========================================================
- Coverage                   90.29%   90.02%   -0.27%     
==========================================================
  Files                          56       56              
  Lines                        3152     3167      +15     
==========================================================
+ Hits                         2846     2851       +5     
- Misses                        306      316      +10
Impacted Files Coverage Δ
Tests/IntegrationTests/ReportEventTypeTests.swift 100% <100%> (ø) :arrow_up:
Sources/PushNotifications.swift 88.51% <100%> (+2.14%) :arrow_up:
...sts/IntegrationTests/DeviceRegistrationTests.swift 100% <100%> (ø) :arrow_up:
...IntegrationTests/MultipleInstanceSupportTest.swift 100% <100%> (ø) :arrow_up:
...ns/PushNotifications/PushNotificationsStatic.swift 27.77% <93.33%> (+2.77%) :arrow_up:
Sources/ServerSyncJob.swift 61.05% <0%> (-12.64%) :arrow_down:
Sources/Internal/ServerSyncProcessHandler.swift 82.85% <0%> (+1.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76e5ea0...141a749. Read the comment docs.