search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Multi instance increase test coverage #140

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

We've added two more tests to ensure that using multiple instances of beams in the same app won't interfere. ...

Why?

We want to ensure that people who do use multiple instances don't have any issues ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #140 into feature-multi-instance will increase coverage by 0.42%. The diff coverage is 100%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature-multi-instance     #140      +/-   ##
==========================================================
+ Coverage                   89.89%   90.31%   +0.42%     
==========================================================
  Files                          56       56              
  Lines                        3186     3243      +57     
==========================================================
+ Hits                         2864     2929      +65     
+ Misses                        322      314       -8
Impacted Files Coverage Δ
...IntegrationTests/MultipleInstanceSupportTest.swift 100% <100%> (ø) :arrow_up:
Sources/ServerSyncJob.swift 69.47% <0%> (+8.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f9b91a...d76c8c6. Read the comment docs.