search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Feature multi instance #141

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

This is all our work to support multiple instances in beams ...

Why?

This will allow customers to use multiple instances in the same app ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #141 into master will decrease coverage by 1.27%. The diff coverage is 90.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   91.75%   90.48%   -1.28%     
==========================================
  Files          52       57       +5     
  Lines        2815     3332     +517     
==========================================
+ Hits         2583     3015     +432     
- Misses        232      317      +85
Impacted Files Coverage Δ
Sources/Persistence/PersistenceConstants.swift 100% <100%> (ø)
Tests/IntegrationTests/ReportEventTypeTests.swift 100% <100%> (ø) :arrow_up:
...IntegrationTests/MultipleInstanceSupportTest.swift 100% <100%> (ø)
...rationTests/MultipleClassInstanceSupportTest.swift 100% <100%> (ø)
Sources/Persistence/Metadata.swift 100% <100%> (ø) :arrow_up:
Tests/Persistence/DeviceStateStoreTests.swift 100% <100%> (ø)
...ts/Persistence/InstanceDeviceStateStoreTests.swift 100% <100%> (ø)
...shNotifications/PushNotifications/InstanceId.swift 100% <100%> (ø)
Tests/EventTypeHandlerTests.swift 93.75% <100%> (+2.08%) :arrow_up:
Tests/Internal/ServerSyncProcessHandlerTests.swift 98.03% <100%> (ø) :arrow_up:
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e65a6f1...c7c971a. Read the comment docs.