search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Fix missing instance id issue #142

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

We fixed the server sync job decoder to not fail all jobs if one job fails. ...

Why?

We need to ensure that the server sync jobs work correctly if one reporting job is missing the instance id ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #142 into feature-multi-instance will increase coverage by 0.4%. The diff coverage is 97.4%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feature-multi-instance     #142     +/-   ##
=========================================================
+ Coverage                   90.07%   90.47%   +0.4%     
=========================================================
  Files                          56       57      +1     
  Lines                        3243     3317     +74     
=========================================================
+ Hits                         2921     3001     +80     
+ Misses                        322      316      -6
Impacted Files Coverage Δ
Sources/ServerSyncJob.swift 67.7% <100%> (+6.65%) :arrow_up:
Tests/EventTypeHandlerTests.swift 93.47% <100%> (+1.37%) :arrow_up:
Sources/Persistence/ServerSyncJobStore.swift 91.37% <100%> (+4.1%) :arrow_up:
Tests/Persistence/ServerSyncJobStoreTests.swift 96.77% <96.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e62bc6c...a91e63d. Read the comment docs.