search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Scope the server sync job store file by instance id #143

Closed daniellevass closed 4 years ago

daniellevass commented 4 years ago

What?

We scoped the job store by instance id ...

Why?

this is important for multiple instances who have jobs to not clash ...

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #143 into feature-multi-instance will decrease coverage by 0.28%. The diff coverage is 100%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature-multi-instance     #143      +/-   ##
==========================================================
- Coverage                   90.47%   90.18%   -0.29%     
==========================================================
  Files                          57       57              
  Lines                        3317     3321       +4     
==========================================================
- Hits                         3001     2995       -6     
- Misses                        316      326      +10
Impacted Files Coverage Δ
Tests/Persistence/ServerSyncJobStoreTests.swift 96.77% <100%> (ø) :arrow_up:
Tests/IntegrationTests/TestHelper.swift 100% <100%> (ø) :arrow_up:
Sources/Internal/ServerSyncProcessHandler.swift 81.13% <100%> (-1.72%) :arrow_down:
Sources/Persistence/ServerSyncJobStore.swift 88.52% <100%> (-2.86%) :arrow_down:
Sources/ServerSyncJob.swift 64.58% <0%> (-3.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebccad5...9031b60. Read the comment docs.