search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Allow register for remote notifications to be called from the static push notifications #145

Closed luismfonseca closed 4 years ago

luismfonseca commented 4 years ago

Why?

There's no reason to depend on the instance push notification.

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #145 into master will increase coverage by 0.16%. The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   90.09%   90.25%   +0.16%     
==========================================
  Files          57       57              
  Lines        3332     3326       -6     
==========================================
  Hits         3002     3002              
+ Misses        330      324       -6
Impacted Files Coverage Δ
Sources/PushNotificationsStatic.swift 27.17% <0%> (+1.13%) :arrow_up:
Sources/PushNotifications.swift 89.72% <50%> (+1.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13a2d70...5360780. Read the comment docs.