search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Fix syntax issues that caused swifc compiler from Xcode 10 (swiftlang-1001) to not be able to determine the correct implicit return type of a closure. #148

Closed grzesiekko closed 4 years ago

grzesiekko commented 4 years ago

What?

A bit more explicit definition of return types for closures that are supposed to return ServerSyncProcessHandler and ServerSyncEventHandler.

Why?

Swift compiler in Xcode 10 is not able to determine the correct return type of closures due to the return type being defined implicitly.

CC @pusher/mobile

codecov-io commented 4 years ago

Codecov Report

Merging #148 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files          57       57           
  Lines        3326     3326           
=======================================
  Hits         3015     3015           
  Misses        311      311
Impacted Files Coverage Δ
Tests/Persistence/ServerSyncJobStoreTests.swift 96.77% <100%> (ø) :arrow_up:
Sources/ServerSyncEventHandler.swift 100% <100%> (ø) :arrow_up:
Sources/Internal/ServerSyncProcessHandler.swift 82.91% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 837f528...d298cb7. Read the comment docs.