pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

Run SwiftLint when building the 'PushNotifications' build target #164

Closed danielrbrowne closed 3 years ago

danielrbrowne commented 3 years ago

There was already a .swiftlint.yml file in the repo, and it was run as part of the Bitrise CI pipeline. However SwiftLint wasn't being run as part of the local build process.

This PR:

codecov-io commented 3 years ago

Codecov Report

Merging #164 (e752668) into master (2924188) will increase coverage by 0.73%. The diff coverage is 82.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   89.45%   90.18%   +0.73%     
==========================================
  Files          57       57              
  Lines        2912     2925      +13     
==========================================
+ Hits         2605     2638      +33     
+ Misses        307      287      -20     
Impacted Files Coverage Δ
Sources/Persistence/Metadata.swift 100.00% <ø> (ø)
Sources/Persistence/PersistenceConstants.swift 100.00% <ø> (ø)
Sources/ReportEventType.swift 33.33% <ø> (-57.15%) :arrow_down:
Tests/AuthDataTests.swift 100.00% <ø> (ø)
Tests/ConstantsTests.swift 100.00% <ø> (ø)
Tests/IntegrationTests/ApplicationStartTests.swift 100.00% <ø> (ø)
...IntegrationTests/MultipleInstanceSupportTest.swift 100.00% <ø> (ø)
Tests/Persistence/DeviceStateStoreTests.swift 100.00% <ø> (ø)
...ts/Persistence/InstanceDeviceStateStoreTests.swift 100.00% <ø> (ø)
Sources/API/NetworkService.swift 68.45% <14.28%> (-6.05%) :arrow_down:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2924188...e752668. Read the comment docs.