search

pusher / push-notifications-swift

Swift SDK for the Pusher Beams product:
https://www.pusher.com/beams
MIT License
34 stars 24 forks source link

[🐜 Bug Report] Xcode 15 fails to locate `PushNotifications.shared` #187

Closed kcw-grunt closed 7 months ago

kcw-grunt commented 7 months ago

Problem

After installing the package per instructions, Xcode is unable to access the framework.

Steps to recreate the issue

  1. Added https://github.com/pusher/push-notifications-swift/ package dependency
  2. Added import PushNotifications to App Delegate
  3. Added let pushNotifications = PushNotifications.shared to App Delegate

Environment

Xcode 15.0.1 Swift version 4.2

App Delegate showing error
Screenshot 2023-11-25 at 2 56 09 PM
benw-pusher commented 7 months ago

I'm not able to replicate the same. Could you share the podfile and podfile.lock? It could be that there is a conflict.

kcw-grunt commented 7 months ago

Thanks @benw-pusher for looking. Actually using the swift package not cocoapods

I noted the docs dont explicit allow as a package but is was found in the Swift Package index/registry and we are not interesting in re-adding Cocoapods.

Did you guys test with the SPM?

benw-pusher commented 7 months ago

I believe this s tested with SPM. Have you followed the instruction here?

kcw-grunt commented 7 months ago

Hi @benw-pusher , Yes I have successfully installed the library into a few projects.

benw-pusher commented 7 months ago

Do all project experience the same issue or just this one?

kcw-grunt commented 7 months ago

No @benw-pusher just this one. My guess is the search paths are borked. But, I tried comparing the two and they seem to be the same. The project is open source. Maybe you can see something obvious? https://github.com/litecoin-foundation/litewallet-ios

kcw-grunt commented 7 months ago

UPDATED: @benw-pusher this was a case of name collision. PushNotifications was already used in the codebase. Refactored accordingly

Closing