TS | hide_notification_if_site_has_focus

pusher / push-notifications-web

Beams Browser notifications

MIT License

39 stars 19 forks source link

TS | hide_notification_if_site_has_focus #108

Closed v1narth closed 2 years ago

v1narth commented 2 years ago

Seems like hide_notification_if_site_has_focus?: string should be boolean instead. If set to any string as defined by the types, it throws an error on runtime:

Using v1.2.5

benw-pusher commented 2 years ago

I believe this is raised in the wrong repo - and is a duplicate of https://github.com/pusher/push-notifications-node/issues/49. I have raised a PR, linked above, to resolve but will close this issue out as it is not an issue with the web repo.