search

pusher / push-notifications-web

Beams Browser notifications
MIT License
39 stars 20 forks source link

Add 'setUserId' functionality #8

Closed lukabratos closed 5 years ago

jonathanlloyd commented 5 years ago

A few points:

* 'Errol' is our internal name for Beams, we shouldn't call it that in the SDK imo.  Maybe `Beams server`

* The test files that are prepended with `sdk-`...surely all the tests are SDK tests one way or another?

There's a few comments in the Token Provider, maybe it can be a separate PR

I disagree with changing the name to BeamsClient - it makes it ease to confuse our internal testing clients with the actual SDK.

In every other SDK we use internal names for testing libraries and neutral names in the actual SDK code