search

pusher / push-notifications-web

Beams Browser notifications
MIT License
39 stars 19 forks source link

Get interests does not implement pagination #80

Open jonathanlloyd opened 3 years ago

jonathanlloyd commented 3 years ago

Bug Report

The getDeviceInterests method does not implement the pagination protocol used by the handler

Reproduction Steps

Call getDeviceInterests on a device that has > 100 subscriptions

Expected Result

All device interests should be returned

Actual Result

Only the first 100 interests (the first page) will be returned

akarsh-jain-790 commented 1 year ago

@britneycodes I would love to work on this.

britneycodes commented 1 year ago

Hey @akarsh-jain-790, it's all yours!

Harsh-br0 commented 1 year ago

Is it still under work? I have already done this locally so can you assign this to me if it's inactive @britneycodes

britneycodes commented 1 year ago

Hey @Harsh-br0, could you create an issue with your solution and we'll be able to accept your solution for hacktoberfest!

Harsh-br0 commented 1 year ago

Hey @Harsh-br0, could you create an issue with your solution and we'll be able to accept your solution for hacktoberfest!

Hi, so I've opened #115 and corresponding pull request #116 to it @britneycodes