search

pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API
https://pusher.com/docs/server_api_guide
1.41k stars 307 forks source link

Support php8 #257

Closed mmachatschek closed 3 years ago

mmachatschek commented 3 years ago

This PR adds support for PHP 8

GrahamCampbell commented 3 years ago

Dropping PHP 7.1 is not necessary.

mmachatschek commented 3 years ago

@GrahamCampbell readded PHP 7.1 support. Forgot that void return types are supported from PHP 7.1.

oyed commented 3 years ago

Is this something that can be merged now?

gileswells commented 3 years ago

Thank you for the PR @mmachatschek.

I'm raising this will the engineering team to see if we can get this prioritized for review / potential merge.

WillSewell commented 3 years ago

This looks good! Thank you for your contribution.