pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API
https://pusher.com/docs/server_api_guide
1.41k stars 307 forks source link

Switch to Guzzle for HTTP calls #289

Closed elverkilde closed 3 years ago

elverkilde commented 3 years ago

Description

I have put this directly in the constructor instead of a new option. It's a fairly non-standard option IMO, so I think that makes sense.

This will be a breaking change, as support for 7.1 is removed and several deprecated functions have been removed. Will be released with new major version.

Related to #95 and #232.

CHANGELOG

caendesilva commented 7 months ago

@elverkilde Hey! Sorry for pinging you here but I just wanted to check something. Was the removal of curl_options an intended change, or just a side effect?

The reason I'm asking is because it breaks self signed certificates (which are very useful for local development) when using Laravel Broadcasting.

Since v5.0.3 no longer works on Laravel 10, this means that there is now no way to use self signed certificates when self-hosting Pusher, for example with Soketi (who documents this issue here https://docs.soketi.app/getting-started/backend-configuration/laravel-broadcasting#self-signed-certificates)

If this was an intentional removal, would you mind letting us know why it was removed? Else, would it be possible to get it added back to the package? I'm happy to try making a PR.