Fix infinite recursion in presence_auth()

pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API

https://pusher.com/docs/server_api_guide

1.42k stars 309 forks source link

Fix infinite recursion in presence_auth() #306

Closed eli-s-r closed 3 years ago

eli-s-r commented 3 years ago

Description

Calling the deprecated presence_auth() function in Pusher.php always leads to infinite recursion since it calls itself with the same arguments. I believe that this was meant to call presenceAuth() instead.

CHANGELOG

[FIXED] Infinite recursion caused by presence_auth()

movntains commented 3 years ago

+1 on this. We're attempting to integrate this package into a production application with a feature that relies upon presence channels, so adding this fix would be much appreciated. 🙂

LoganTFox commented 3 years ago

LowSociety commented 3 years ago

This really got me digging. Laravel uses this internally when joining a presence channel, so a fresh installation of Laravel and Pusher 7.0 will cause a 500 http response.

stayallive commented 3 years ago

This explains a lot, thanks for creating the PR. Hopefully this can released soon-ish!

elverkilde commented 3 years ago

hi all, sorry for the delay on this one. We monitor GH issues, but unfortunately it doesn't seem to alert us on PR's so this one was missed. This is now released as version 7.0.1.