pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API
https://pusher.com/docs/server_api_guide
1.41k stars 307 forks source link

Added the possibility of passing query params to the getPresenceUsers #327

Closed HenriqueSPin closed 1 year ago

HenriqueSPin commented 2 years ago

Description

Added the possibility of passing query params to the getPresenceUsers and the (deprecated) get_users_info in order to support the feature implemented by Soketi, and, hopefully, Pusher, where we can add a with_user_info=1 to this endpoint.

https://github.com/soketi/soketi/pull/450

The addition is retro compatible and does not impact current implementations.

CHANGELOG

sonologico commented 2 years ago

Looks good. I'll merge it soon. Thank you!

EDIT: Approved too fast without full context. We don't actually take extra parameters on this endpoint. This doesn't seem to make sense right now.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.