pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API
https://pusher.com/docs/server_api_guide
1.4k stars 306 forks source link

The CI setup is not friendly to community contributors #361

Closed stof closed 1 year ago

stof commented 1 year ago

The CI setup currently uses the same jobs to run standalone commands (unit tests, linting) and acceptance tests that require access to secrets. For PRs sent from a fork, secrets are not available (for security reasons) and so the CI marks all jobs as failed due to acceptance tests.

For a better experience, the CI jobs could be split:

benjamin-tang-pusher commented 1 year ago

Thanks for this suggestion. I will pass to this feedback to our engineering.

I will close this GH issue.