pusher / pusher-http-php

PHP library for interacting with the Pusher Channels HTTP API
https://pusher.com/docs/server_api_guide
1.41k stars 309 forks source link

Check check for null values for host and cluster #367

Closed maskeynihal closed 1 year ago

maskeynihal commented 1 year ago

Description

If the configuration is set as follows

$options = [
  'host' => null, 
  'cluster' => null
]

Then, array_key_exists will only check if the key exists or not and will not check if the value is empty. If the keys exist and the value is null, then the URL generated will be null when host is null or api-.pusher.com when cluster is null.

This causes an error in calling the URL of the pusher.

CHANGELOG

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.