search

pusher / pusher-http-python

Pusher Channels HTTP API library for Python
https://pusher.com/docs/server_api_guide
MIT License
376 stars 113 forks source link

Test versions 3.5 and 3.6 with travis #110

Closed WillSewell closed 6 years ago

WillSewell commented 6 years ago

The original goal of this PR was to test versions 3.5 and 3.6.

However it turned out that the tests fail entirely because the latest version of tornado (a dependency) no longer supports Python 2.6 and 3.3 due to security vulnerabilities. I think this is a strong motivation for dropping support in this library too. For reference, the last Python 2.6 release was 2013-10-29 and the last 3.2 release was 2014-10-12.

Thoughts @callum-oakley?

WillSewell commented 6 years ago

I'm going to go ahead and merge this.

WillSewell commented 6 years ago

The tests now seem to be failing, and I'm not sure why. I'm going to revert this branch on master and figure out what the problem is when I have more time.

callum-oakley commented 6 years ago

Ahh sorry @WillSewell, didn't see this the other day :grimacing: In response to the original question dorpping support sounds like a good idea :+1:

Happy to take a look at the test failures with you at some point if that's still an issue.