search

pusher / pusher-http-python

Pusher Channels HTTP API library for Python
https://pusher.com/docs/server_api_guide
MIT License
375 stars 112 forks source link

specify urllib3 version requirement in setup.py #142

Closed dpinol closed 5 years ago

dpinol commented 5 years ago

Hi, I've seen that requirement.txt has "urllib3==1.24" (as many other libraries, eg. requests) which forbid version 1.25). But setup.py does not contain any version specification for urllib3. Can you add the requirement also in setup.py? Otherwise setup.py causes 1.25 to be installed, which conflicts with other libraries which forbid it

thanks

WillSewell commented 5 years ago

Thanks for letting us know about this.

I'd like to avoid pinning to a specific version of urllib3 in setup.py because ideally users of this library should have as much flexibility as possible in terms of the versions of other dependencies they can use. It's the responsibility of the user of the library and their package manager to install compatible versions.

The latest version of urllib3 (1.5.2) is compatible with the latest version of requests (2.22.0), so installing the latest versions of both should lead to now issues. Please let me know if I'm missing something.