search

pusher / pusher-http-python

Pusher Channels HTTP API library for Python
https://pusher.com/docs/server_api_guide
MIT License
376 stars 113 forks source link

Fix AuthenticationClient for encrypted channels #145

Closed ericmarcos closed 5 years ago

ericmarcos commented 5 years ago

The function generate_shared_secret expects the first argument "channel" in binary for Python 3, but it was passed as a string. That caused a TypeError: can only concatenate str (not "bytes") to str exception when using authenticate with encryption.

damdo commented 5 years ago

Ah! Thank you @ericmarcos nice catch!

damdo commented 5 years ago

I'll add a test for it in a separate PR.