search

pusher / pusher-http-python

Pusher Channels HTTP API library for Python
https://pusher.com/docs/server_api_guide
MIT License
375 stars 112 forks source link

[Snyk] Security upgrade cryptography from 2.6.1 to 3.3.2 #168

Closed WillSewell closed 3 years ago

WillSewell commented 3 years ago

Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

Vulnerabilities that will be fixed

By pinning:
Severity Priority Score (*) Issue Upgrade Breaking Change Exploit Maturity
medium severity 581/1000
Why? Recently disclosed, Has a fix available, CVSS 5.9		 Cryptographic Issues
SNYK-PYTHON-CRYPTOGRAPHY-1070544		 cryptography:
2.6.1 -> 3.3.2
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the effected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

WillSewell commented 3 years ago

I needed to drop support for EoL Python 3.5 because it is not compatible with the newer version of cryptography.

yoursvivek commented 3 years ago

@WillSewell Now that this PR is merged, releasing a new version and uploading it to pypi will help.

WillSewell commented 3 years ago

I'm not sure it would because this is only the version specified in the requirements.txt file that's used for local deveopment/tests. There's nothing stopping users of the library using whichever compatible version of cryptography they like.