Allow client timeout to be a float - Githubissues

pusher / pusher-http-python

Pusher Channels HTTP API library for Python

https://pusher.com/docs/server_api_guide

MIT License

375 stars 112 forks source link

Allow client timeout to be a float #195

Closed edmundlam closed 1 year ago

edmundlam commented 1 year ago

What does this PR do?

Allow the client to accept a float as a timeout.

The underlying requests library used by pusher allows floats to be used when making requests. (see https://requests.readthedocs.io/en/latest/api/#requests.request)

Related issue: https://github.com/pusher/pusher-http-python/issues/194

CHANGELOG

[ADDED] Allow Client to accept float as a timeout
[CHANGED] the maximum event payload size permitted by this library has been increased. This change affects the library only: the Channels API still maintains a 10kb size limit and will return an error if the payload is too large.

edmundlam commented 1 year ago

@benjamin-tang-pusher just a friendly bump, is there anything else that needs to be done before we could merge this?