search

pusher / pusher-http-ruby

Ruby library for Pusher Channels HTTP API
https://pusher.com/channels
MIT License
664 stars 124 forks source link

update travis config #145

Closed annzenkina closed 5 years ago

annzenkina commented 5 years ago

Thanks for your comments @kn100 . I don't have a strong opinion here. I guess 2.X.0 will do, since the last digit is represent minor changes. But I don't see why not to change it to 2.4.6.

I think we agreed with @jameshfisher that we explicitly saying that we support only about the latest stable version. @jameshfisher can you take a look at the PR please. Is this how you imagined it?

kn100 commented 5 years ago

I guess it doesn't actually make a difference. I'll LGTM this.

jameshfisher commented 5 years ago

We should decide what we want to support before we look at which things we test.

Which versions we want to support is mostly informed by which versions are in use. Looking at this survey, "Ruby 2.3+" would give us 80%+ support. Since we already have tests for those, they're passing, and those versions are relatively recent, it seems low effort to list "Ruby 2.3+" in the ## Supported platforms section of the README.

I wouldn't worry about patch versions, just major and minor. Patch version is too low-level for support discussions. I think convention in Travis would be to test against e.g. 2.2 rather than 2.2.0. This should give Travis the freedom to pick the latest patch version.

Which versions we test against is a slightly different question to which versions we support. But I think it makes sense to keep these in sync, as you've done by removing 1.9 etc.