Closed y-yagi closed 4 years ago
Some gems, such as ruby-jwt, try to load rbnacl when library loaded. https://github.com/jwt/ruby-jwt/blob/0f7dd575a3324a4aefe769a1f7d381efe2141771/lib/jwt/signature.rb#L11-L15
ruby-jwt
rbnacl
Because of this, if rbnacl exists in dependencies, cause of libsodium load error.
libsodium
Therefore, it is better to have it specified in the user's Gemfile instead of making it dependency of gem.
Gemfile
Fixes #161.
Looks good, thanks for this!
Thanks for your review!
Some gems, such as
ruby-jwt
, try to loadrbnacl
when library loaded. https://github.com/jwt/ruby-jwt/blob/0f7dd575a3324a4aefe769a1f7d381efe2141771/lib/jwt/signature.rb#L11-L15Because of this, if
rbnacl
exists in dependencies, cause oflibsodium
load error.Therefore, it is better to have it specified in the user's
Gemfile
instead of making it dependency of gem.Fixes #161.