search

pusher / pusher-http-ruby

Ruby library for Pusher Channels HTTP API
https://pusher.com/channels
MIT License
664 stars 123 forks source link

Don't add `rbnacl` as dependency #162

Closed y-yagi closed 4 years ago

y-yagi commented 4 years ago

Some gems, such as ruby-jwt, try to load rbnacl when library loaded. https://github.com/jwt/ruby-jwt/blob/0f7dd575a3324a4aefe769a1f7d381efe2141771/lib/jwt/signature.rb#L11-L15

Because of this, if rbnacl exists in dependencies, cause of libsodium load error.

Therefore, it is better to have it specified in the user's Gemfile instead of making it dependency of gem.

Fixes #161.

callum-oakley commented 4 years ago

Looks good, thanks for this!

y-yagi commented 4 years ago

Thanks for your review!