Handle nil cluster, minor refactor

pusher / pusher-http-ruby

Ruby library for Pusher Channels HTTP API

https://pusher.com/channels

MIT License

664 stars 124 forks source link

Handle nil cluster, minor refactor #170

Closed GeorgeRDBuckley closed 3 years ago

GeorgeRDBuckley commented 3 years ago

Description

Refactored the client class
Fixes bug if cluster option is nil #157

CHANGELOG

[Fixed] Fall back to default mt1 cluster if cluster is set to nil or the empty string.

elverkilde commented 3 years ago

@jakswa this doesn't actually change the host, api.pusherapp.com is a legacy endpoint, pointing to api-mt1.pusher.com

jakswa commented 3 years ago

Thank you! That makes sense. That helps confirm that it isn't an alarming change. I'll go digging for details on pusherapp.com deprecation. I am just updating our HTTP stubs and referencing why.