search

pusher / pusher-http-ruby

Ruby library for Pusher Channels HTTP API
https://pusher.com/channels
MIT License
664 stars 124 forks source link

DEPRECATION WARNING `request#content_type` in Rails v7.0.1 #179

Closed mpg-tomohiko-mimura closed 1 year ago

mpg-tomohiko-mimura commented 2 years ago

The following deprecated warning will be generated when executing pusher.webhook(request) in Rails v7.0.1.

DEPRECATION WARNING: Rails 7.1 will return Content-Type header without modification. If you want just the MIME type, please use `#media_type` instead.

This is a warning for a change in Railsv7.1. ref. https://github.com/rails/rails/commit/840551307139324300b943901d84cbacba11862d

Depending on the value of CONTENT_TYPE in the webhook, rails v7.1 will not work properly.

Should we use request#media_type? https://github.com/pusher/pusher-http-ruby/blob/08af7fba7c52f95f9a6d7ac7c6da603fbda80502/lib/pusher/webhook.rb#L37

Let me know what the Pusher development team thinks.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

mpg-tomohiko-mimura commented 2 years ago

@elverkilde

What do you think about this issue?

yoLotus commented 2 years ago

Hello, is there any update planned for this deprecation?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.