pusher / pusher-js

Pusher Javascript library
http://pusher.com
MIT License
2.11k stars 374 forks source link

https://js.pusher.com/8.0.1/pusher.min.js blocked by AdBlock (net::ERR_BLOCKED_BY_CLIENT) #753

Closed dtinth closed 1 year ago

dtinth commented 1 year ago

Do you want to request a feature or report a bug? Bug

What is the current behavior? AdBlock extension seems to be blocking Pusher. This is affecting our users.

<script src="https://js.pusher.com/8.0.1/pusher.min.js"></script>

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.

  1. Install AdBlock
  2. Enable these filters image
  3. Go to a website with Pusher

What is the expected behavior? Pusher.js should load correctly.

Which versions of Pusher, and which browsers / OS are affected by this issue? Did this work in previous versions of Pusher? If so, which? Version 3.1 is also affected.

benw-pusher commented 1 year ago

I'm not able to reproduce this with adblock. Can you try disabling individual lists and let me know which one appears to be the culprit? I can then investigate the list source directly.

dtinth commented 1 year ago

@benw-pusher Thanks for the suggestion. I tried as suggested and it turns out it’s not the filter lists that blocked the Pusher SDK.

Turns out, it’s the Distraction Control feature available to AdBlock Premium (which costs $2/mo). I think this feature recently rolled out. I did not remember enabling it, so I guess it may be enabled by default for paying customers.

image

Since it is a paid feature, I also opened a support ticket to AdBlock side and will update when I hear back.

benw-pusher commented 1 year ago

Thanks @dtinth . I suspect this is not something that AdBlock will change, as that would be circumventing the purpose of distraction control. One workaround for this could be to self serve the files, hosting them on your domain instead of a Pusher domain and potentially preventing the block - however I can't guarantee this is a solution as I'm not certain how the distraction control works.

dtinth commented 1 year ago

Yes, you are right, received this response from AdBlock:

Thank you for your patience.

After consideration, the Distraction Control team has opted to continue blocking Pusher as it uses push notifications.

We may have to self host it then. Thanks for the suggestion 🙏