search

pusher / pusher-platform-ruby

Sample authorizer component in Ruby
0 stars 4 forks source link

ErrorResponse properties are nested in a hash under error_description instead of in their own attributes #19

Closed CarlLooksUp closed 6 years ago

CarlLooksUp commented 6 years ago

What?

ErrorResponse properties (error, error_uri, error_description) are nested in a hash under error_description instead of in their own attributes.

Suggested improvements

Change invocation of ErrorResponse constructor to unpack data across the class fields.

CC @pusher/sigsdk

hamchapman commented 6 years ago

Hey @CarlLooksUp where are you seeing this happen?

As far as I can see from the code it looks like it should be assigning attributes correctly

hamchapman commented 6 years ago

Fixed in #20 - thanks @CarlLooksUp !

I'll publish a new version right now 👍