Unify errors under a single PusherPlatform::Error class

pusher / pusher-platform-ruby

Sample authorizer component in Ruby

0 stars 4 forks source link

Unify errors under a single PusherPlatform::Error class #22

Closed hamchapman closed 6 years ago

hamchapman commented 6 years ago

What?

See title

Why?

Make it straightforward for users of the SDK to rescue all errors being raised by this SDK so that they can do things like namespace however they like, for example.

[x] README updated if you changed the API?
[x] CHANGELOG updated if relevant?

CC @pusher/sigsdk

BenPope commented 6 years ago

Looks consistent, aside from capitalisation. @vivangkumar ?

hamchapman commented 6 years ago

What capitalisation?

BenPope commented 6 years ago

In the error strings returned. The capitalisation here makes more sense.

vivangkumar commented 6 years ago

Does look good. Although we don't currently return errors in the platform-go library for these checks. Perhaps we should?

hamchapman commented 6 years ago

What do you do there instead?