search

pusher / pusher-websocket-dotnet

Pusher Channels Client Library for .NET
MIT License
112 stars 113 forks source link

Please make a version for .net Core 2.0 #45

Closed kooboo-binbin closed 3 years ago

kooboo-binbin commented 6 years ago

Please make a version for .net Core 2.0

imaji commented 6 years ago

Hi,

Yes, we're just looking at timescales to make a .net standard compliant version.

I haven't got a date for you yet though.

Best regards, John

nicolasguzca commented 6 years ago

Hi John, any updates on the .net Core 2.0 version?

justin-lavelle commented 6 years ago

I have a fork for netstandard2.0 https://github.com/justin-lavelle/pusher-websocket-dotnet-netstandard It's also on nuget PusherClient.NetStandard

Misiu commented 5 years ago

@justin-lavelle could You make a PR with all the changes?

imaji commented 5 years ago

I've got a version we're going to merge in shortly that adds in support for .net standard 1.6 & 2.0

Misiu commented 5 years ago

@imaji awesome news 😄

bddckr commented 5 years ago

Will the Standard compliant version still include WebSocket4Net or is System.Net.WebSockets.ClientWebSocket enough?

I'm having a hard time figuring out whether it supports the same OS/device combinations besides being part of .NET Standard 2.0 and whether that's an issue for this library.

Misiu commented 5 years ago

@imaji any updates?

Misiu commented 5 years ago

ping

kn100 commented 5 years ago

Hi @Misiu - I will also bring this up in our next standup and keep you up to date on our plans.

Misiu commented 5 years ago

@kn100 any updates? I've noticed that recent PR added support for neststandard1.6, why can't You add both? netstandard2.0 has a smaller dependency tree, so it is preferred by many developers. Take a look at how RabbitMQ did it:rabbitmq/rabbitmq-dotnet-client#428 (comment)

Misiu commented 5 years ago

@damdo any updates?

damdo commented 4 years ago

Hey all! So currently the library supports .NET standard 1.6, but yes .NET standard 2.0 (and thus .NET Core 2.0) is on our radar. We are currently focused on improving certain behaviours of the library / fixing some issues, but extending the compatibility is next 👍

elverkilde commented 3 years ago

This issue was fixed in #104 which was released as version 2.0.0. Please be aware that this is a major release, with several breaking changes. We have written a migration guide here:

https://github.com/pusher/pusher-websocket-dotnet#migrating-from-version-1-to-version-2