search

pusher / pusher-websocket-dotnet

Pusher Channels Client Library for .NET
MIT License
112 stars 113 forks source link

`/p:OutputPath=.\ ` in `package.cmd` makes all binaries same! #80

Closed kenjiuno closed 4 years ago

kenjiuno commented 4 years ago

/p:OutputPath=.\ in package.cmd makes net45, net46 and netstandard1.6 binaries same.

https://github.com/pusher/pusher-websocket-dotnet/blob/b9cf229a1f5c657ce5577f55fce377bc1bd9b5ee/package.cmd#L3

Please check same 98df0b35 CRC-32 values printed from unzip.

USER@DD36 ~
$ unzip -v /cygdrive/d/DL/pusherclient.1.0.2.nupkg
Archive:  /cygdrive/d/DL/pusherclient.1.0.2.nupkg
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
     506  Defl:N      273  46% 06-18-2019 10:53 88afae54  _rels/.rels
    2157  Defl:N      605  72% 06-18-2019 10:53 bb628f90  PusherClient.nuspec
   40960  Defl:N    17118  58% 06-18-2019 09:53 98df0b35  lib/net45/PusherClient.dll
   40960  Defl:N    17118  58% 06-18-2019 09:53 98df0b35  lib/net46/PusherClient.dll
   40960  Defl:N    17118  58% 06-18-2019 09:53 98df0b35  lib/netstandard1.6/PusherClient.dll
     465  Defl:N      207  56% 06-18-2019 10:53 bc4d7cde  [Content_Types].xml
     774  Defl:N      453  42% 06-18-2019 10:53 d0e43126  package/services/metadata/core-properties/ffa56fe658a247c99ecc8fa97973a1d6.psmdcp
    9468  Stored     9468   0% 06-18-2019 03:04 2c04e5e3  .signature.p7s
--------          -------  ---                            -------
  136250            62360  54%                            8 files

Verified by sha512 hash output. I have extracted PusherClient.dll files from pusherclient.1.0.2.nupkg

USER@DD36 ~
$ sha512sum.exe `find /cygdrive/c/Users/USER/Desktop/lib -name PusherClient.dll`
181a209cec5aefddd5495c2d2d6dbfa65d056ba4a084be26d14ba77ef7679b66bbca8b5a79a044d0067f18b876821a64508775eff1d93faef4125d592f08dd4b */cygdrive/c/Users/USER/Desktop/lib/net45/PusherClient.dll
181a209cec5aefddd5495c2d2d6dbfa65d056ba4a084be26d14ba77ef7679b66bbca8b5a79a044d0067f18b876821a64508775eff1d93faef4125d592f08dd4b */cygdrive/c/Users/USER/Desktop/lib/net46/PusherClient.dll
181a209cec5aefddd5495c2d2d6dbfa65d056ba4a084be26d14ba77ef7679b66bbca8b5a79a044d0067f18b876821a64508775eff1d93faef4125d592f08dd4b */cygdrive/c/Users/USER/Desktop/lib/netstandard1.6/PusherClient.dll

So please exclude /p:OutputPath=.\ from package.cmd:

"%ProgramFiles(x86)%\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\amd64\msbuild.exe" PusherClient/PusherClient.csproj /t:pack /p:Configuration=Release

Although this will produce nupkg in Release folder, all binaries are separatedly built and composed.

USER@DD36 ~
$ sha512sum.exe `find /cygdrive/c/Users/USER/Desktop/lib -name PusherClient.dll`
69b0b6a08503d2c11750660469323effe9ceb9b80062c6095504dc5fcc7d808f6d3ed805fd20848ae7dac7b2de082475056db59b43a6de2075e628cb91b65d4c */cygdrive/c/Users/USER/Desktop/lib/net45/PusherClient.dll
dee2555bd9d74ca24fcfc49e291694417615cb0c4758fa777caf04091f39152f4d45376cdf1b67d227a42bbef63bbfd532d909c6237a1418bee78f120d770afe */cygdrive/c/Users/USER/Desktop/lib/net46/PusherClient.dll
9d5cc830920ef8ca8579e825e1acf84ff8ecc670b69bf4500940250065a30da0a8199350d6069ea3ffa12b29cf66145cb3c66350d428b7fffb57ae1f56063376 */cygdrive/c/Users/USER/Desktop/lib/netstandard1.6/PusherClient.dll
imaji commented 4 years ago

Done, it's on the branch feature/ConcurrentDictionary, which should be released shortly.

kenjiuno commented 4 years ago

@imaji Thanks for rapid catch up!