search

pusher / stronghold

[DEPRECATED] A configuration service | owner: @willsewell
12 stars 1 forks source link

Imports standardize #4

Closed nmattia closed 8 years ago

nmattia commented 8 years ago

@WillSewell @mdpye Made imports explicit, sorted imports alphabetically, made (some) HLint changes and wrapped lines at 80 chars

mdpye commented 8 years ago

Were these changes automated?

nmattia commented 8 years ago

Unfortunately not.

nmattia commented 8 years ago

@WillSewell I also ordered the functions imported by alphabetical order, it would be nice if you could check

WillSewell commented 8 years ago

@Nicowcow looks good. Added some comments.

nmattia commented 8 years ago

@WillSewell if you could check this

zimbatm commented 8 years ago

LGTM

WillSewell commented 8 years ago

Is there a reason why you didn't implement some of my suggestions. e.g. https://github.com/pusher/stronghold/pull/4/files#r49448023

nmattia commented 8 years ago

reason is that I forgot to push

zimbatm commented 8 years ago

Good enough

WillSewell commented 8 years ago

I don't think we should be merging WIP commits into master...