search

pushkin-consortium / pushkin-exptemplates-basic

Basic jsPsych experiment with a "hello world" timeline.
MIT License
0 stars 6 forks source link

Bump browserslist from 4.13.0 to 4.20.4 in /web page #23

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 2 years ago

Bumps browserslist from 4.13.0 to 4.20.4.

Changelog

Sourced from browserslist's changelog.

4.20.4

  • Fix Opera in mobileToDesktop (by Pig Fang).

4.20.3

  • Add Baidu to dead browsers (by Igor Lukanin).

4.20.2

  • Fixed package.funding URL format.

4.20.1

  • Fixed package.funding.
  • Fixed docs (by Michael Lohmann).

4.20

  • Added last 2 node versions and last 2 node major versions (by @​g-plane).

4.19.3

  • Updated Firefox ESR (by Christophe Coevoet).

4.19.2

  • Fixed --help output.

4.19.1

  • Fixed throwOnMissing types (by Øyvind Saltvik).

4.19

  • Added queries grammar definition (by Pig Fang).
  • Added throwOnMissing option (by Øyvind Saltvik).
  • Fixed null data ignoring in < 50% in CN (byPig Fang).
  • Fixed data parsing in in my stats (by Sun Xiaoran).
  • Fixed yarn.lock support with integrity (by Alexey Berezin).
  • Fixed Yarn Berry error message in --update-db.

4.18.1

  • Fixed case inventiveness for cover queries (by Pig Fang).
  • Fixed since 1970 query for null in release date (by Pig Fang).

4.18

  • Added --ignore-unknown-versions CLI option (by Pig Fang).

4.17.6

  • Fixed sharable config resolution (by Adaline Valentina Simonian).

4.17.5

  • Fixed --update-db for some pnpm cases.

4.17.4

  • Reduced package size.

4.17.3

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pushkin-consortium/pushkin-exptemplates-basic/network/alerts).
Halogen7A commented 1 year ago

I am getting an error with this pull request. It is showing a missing config.yaml file in the experiment folder.

image

Halogen7A commented 1 year ago

I have tried installing different experiments and it consistently threw me file not found error. image

jkhartshorne commented 1 year ago

Look at the 5th line. You've already got a directory with the same name, so installing the experiment didn't work. 

On August 1, 2023, Sebastian Waz @.***> wrote:

I am getting an error with this pull request. It is showing a missing config.yaml file in the experiment folder.

  — Reply to this email directly, view it on GitHub https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/23#issuecomment-1660929903, or unsubscribe https://github.com/notifications/unsubscribe- auth/ABOVVYYQCKKF4UOXC6SZSG3XTFIKNANCNFSM5YQQVZUA. You are receiving this because you are subscribed to this thread.Message ID: <pushkin-consortium/pushkin-exptemplates- @.***>

-- Sent with HEY https://hey.com/sent

jessestorbeck commented 1 year ago

I'm getting a different error from prep after I install an experiment from this branch. I checked and I'm not getting this error when I install with the normal basic template:

jessestorbeck@jesses-air-4 browserslistTest % pushkin prep Removing any .DS_Store files, if present. /Users/jessestorbeck/Desktop/browserslistTest/experiments /Users/jessestorbeck/Desktop/browserslistTest/pushkin package manager: yarn resetting experiments.js Started prepping API for test Started loading API controller for test Using build-if-changed for test_api Installing dependencies for /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/api controllers Started prepping web page for test Started loading web page for test Using build-if-changed for test_web Installing dependencies for /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/web page loaded docker-compose.dev.yml and pushkin.yaml. Building worker for test Building docker image for test_worker docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load userMigsDir: /Users/jessestorbeck/Desktop/browserslistTest/users/migrations userDatabase: localtestdb Loading migrations for test Updated users/config.yaml to be compatible with default site template v2+. expConfig: {"experimentName":"test","shortName":"test","apiControllers":{"mountPath":"test","location":"api controllers","name":"mycontroller"},"worker":{"location":"worker","service":{"image":"test","links":["message-queue","test_db"],"environment":{"AMQP_ADDRESS":"amqp://message-queue:5672","DB_USER":"postgres","DB_PASS":"example","DB_URL":"test_db","DB_NAME":"test_db"}}},"webPage":{"location":"web page"},"migrations":{"location":"migrations"},"seeds":{"location":""},"database":"localtestdb","logo":"logo512.png","text":"Enter your experiment description here.","tagline":"Be a citizen scientist! Try this quiz.","duration":"","productionDB":"Main"} Waiting for database to start... Waiting for test db... Building test_api from /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/api controllers Building test_web from /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/web page test_api is built test_web is built test_api is published locally via yalc Waiting for test db... test_web is published locally via yalc Loaded web page for test (test_web) Added test to experiments.js Writing out experiments.js Installing combined API Installed combined API Installing combined front-end Installed combined front-end Error: Command failed: docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load

1 [internal] load build definition from Dockerfile

1 transferring dockerfile: 263B 0.0s done

1 DONE 0.0s

2 [internal] load .dockerignore

2 transferring context: 73B done

2 DONE 0.0s

3 [internal] load metadata for docker.io/library/node:latest

3 ERROR: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found

[internal] load metadata for docker.io/library/node:latest:

ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found

at ChildProcess.exithandler (node:child_process:419:12)
at ChildProcess.emit (node:events:511:28)
at maybeClose (node:internal/child_process:1098:16)
at ChildProcess._handle.onexit (node:internal/child_process:304:5) {

code: 1, killed: false, signal: null, cmd: 'docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load', stdout: '', stderr: '#1 [internal] load build definition from Dockerfile\n' + '#1 transferring dockerfile: 263B 0.0s done\n' + '#1 DONE 0.0s\n' + '\n' + '#2 [internal] load .dockerignore\n' + '#2 transferring context: 73B done\n' + '#2 DONE 0.0s\n' + '\n' + '#3 [internal] load metadata for docker.io/library/node:latest\n' + '#3 ERROR: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found\n' + '------\n' + ' > [internal] load metadata for docker.io/library/node:latest:\n' + '------\n' + 'ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found\n' }

jkhartshorne commented 1 year ago

When you are installing from this branch, you updated the branch first, right? (Pulling from the master?)

On August 1, 2023, Sebastian Waz @.***> wrote:

I'm getting a different error from prep after I install an experiment from this branch. I checked and I'm not getting this error when I install with the normal basic template:

@.*** browserslistTest % pushkin prep  Removing any .DS_Store files, if present.  /Users/jessestorbeck/Desktop/browserslistTest/experiments  /Users/jessestorbeck/Desktop/browserslistTest/pushkin  package manager: yarn  resetting experiments.js  Started prepping API for test  Started loading API controller for test  Using build-if-changed for test_api  Installing dependencies for /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/api controllers  Started prepping web page for test  Started loading web page for test  Using build-if-changed for test_web  Installing dependencies for /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/web page  loaded docker-compose.dev.yml and pushkin.yaml.  Building worker for test  Building docker image for test_worker  docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load  userMigsDir: /Users/jessestorbeck/Desktop/browserslistTest/users/migrations  userDatabase: localtestdb  Loading migrations for test  Updated users/config.yaml to be compatible with default site template v2+.  expConfig:  {"experimentName":"test","shortName":"test","apiControllers":{"mountPath":"test","location":"api controllers","name":"mycontroller"},"worker":{"location":"worker","service":{"image":"test","links":["message- queue","test_db"],"environment":{"AMQP_ADDRESS":"amqp://message- queue:5672","DB_USER":"postgres","DB_PASS":"example","DB_URL":"test_db","DB_NAME":"test_db"}}},"webPage":{"location":"web page"},"migrations":{"location":"migrations"},"seeds":{"location":""},"database":"localtestdb","logo":"logo512.png","text":"Enter your experiment description here.","tagline":"Be a citizen scientist! Try this quiz.","duration":"","productionDB":"Main"}  Waiting for database to start...  Waiting for test db...  Building test_api from /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/api controllers  Building test_web from /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/web page  test_api is built  test_web is built  test_api is published locally via yalc  Waiting for test db...  test_web is published locally via yalc  Loaded web page for test (test_web)  Added test to experiments.js  Writing out experiments.js  Installing combined API  Installed combined API  Installing combined front-end  Installed combined front-end  Error: Command failed: docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load  #1 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/1 [internal] load build definition from Dockerfile

1 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/1> transferring dockerfile: 263B 0.0s done

1 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/1> DONE 0.0s

2 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/2> [internal] load .dockerignore

2 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/2> transferring context: 73B done

2 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/2> DONE 0.0s

3 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/3> [internal] load metadata for docker.io/library/node:latest

3 <https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/3> ERROR: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found

[internal] load metadata for docker.io/library/node:latest:

ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found

at ChildProcess.exithandler (node:child_process:419:12) at ChildProcess.emit (node:events:511:28) at maybeClose (node:internal/child_process:1098:16) at ChildProcess._handle.onexit (node:internal/child_process:304:5) { code: 1,  killed: false,  signal: null,  cmd: 'docker buildx build /Users/jessestorbeck/Desktop/browserslistTest/experiments/test/worker --platform linux/x64 -t test_worker --load',  stdout: '',  stderr: '#1 https://github.com/pushkin-consortium/pushkin- exptemplates-basic/pull/1 [internal] load build definition from Dockerfile\n' + '#1 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/1 transferring dockerfile: 263B 0.0s done\n' + '#1 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/1 DONE 0.0s\n' + '\n' + '#2 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/2 [internal] load .dockerignore\n' + '#2 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/2 transferring context: 73B done\n' + '#2 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/2 DONE 0.0s\n' + '\n' + '#3 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/3 [internal] load metadata for docker.io/library/node:latest\n' + '#3 https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/3 ERROR: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found\n' + '------\n' + ' > [internal] load metadata for docker.io/library/node:latest:\n' + '------\n' + 'ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:64b71834718b859ea389790ae56e5f2f8fa9456bf3821ff75fa28a87a09cbc09: not found\n' }

— Reply to this email directly, view it on GitHub https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/23#issuecomment-1661045741, or unsubscribe https://github.com/notifications/unsubscribe- auth/ABOVVYZBZJ7EUJIW47MXYI3XTFRKPANCNFSM5YQQVZUA. You are receiving this because you commented.Message ID: <pushkin- @.***>

-- Sent with HEY https://hey.com/sent

Halogen7A commented 1 year ago

Look at the 5th line. You've already got a directory with the same name, so installing the experiment didn't work. … On August 1, 2023, Sebastian Waz @.> wrote: I am getting an error with this pull request. It is showing a missing config.yaml file in the experiment folder. — Reply to this email directly, view it on GitHub <https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/23#issuecomment-1660929903>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/ABOVVYYQCKKF4UOXC6SZSG3XTFIKNANCNFSM5YQQVZUA>. You are receiving this because you are subscribed to this thread.Message ID: <pushkin-consortium/pushkin-exptemplates- @.> -- Sent with HEY https://hey.com/sent

I noticed that too. I changed the name to "tester" or "test123" and in both cases I have received a file not found error.

jkhartshorne commented 1 year ago

Please post that output.

On August 1, 2023, Sebastian Waz @.***> wrote:

Look at the 5th line. You've already got a directory with the same name, so installing the experiment didn't work.  … <#> On August 1, 2023, Sebastian Waz @.> wrote: I am getting an error with this pull request. It is showing a missing config.yaml file in the experiment folder. — Reply to this email directly, view it on GitHub <<https://github.com/pushkin-consortium/pushkin-exptemplates-

basic/pull/23#issuecomment-1660929903>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/ABOVVYYQCKKF4UOXC6SZSG3XTFIKNANCNFSM5YQQVZUA>. You are receiving this because you are subscribed to this thread.Message ID: <pushkin-consortium/pushkin-exptemplates- @.> -- Sent with HEY https://hey.com/sent

I noticed that too. I changed the name to "tester" or "test123" and in both cases I have received a file not found error.

— Reply to this email directly, view it on GitHub https://github.com/pushkin-consortium/pushkin-exptemplates- basic/pull/23#issuecomment-1661056502, or unsubscribe https://github.com/notifications/unsubscribe- auth/ABOVVY7GIL5535NNERQDCUTXTFSIDANCNFSM5YQQVZUA. You are receiving this because you commented.Message ID: <pushkin- @.***>

-- Sent with HEY https://hey.com/sent

jessestorbeck commented 1 year ago

@jkhartshorne, I had not but now that makes more sense. In this case, it does tell me there are conflicts between the branches.

Halogen7A commented 1 year ago

257621305-38ebe61d-d863-457f-ab77-fc19e51f8a6d

jkhartshorne commented 1 year ago

The issue is in yarn.lock. Looking there, it seems that the version of browserslist in master is actually more recent than the one in this pull request. So there's no need to do the upgrade anyway.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.