Closed jessestorbeck closed 2 months ago
Latest commit: 2c9609743f32c15a6e812daeb15188bc481a3864
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@hunterschep,
There are some dependency warnings for the different experiment templates, would we be able to resolve this
Are you referring to these when you install the first experiment template in your site?
warning @pushkin-templates/exp-basic > jest-environment-jsdom > jsdom > abab@2.0.6: Use your platform's native atob() and btoa() methods instead
warning @pushkin-templates/exp-basic > jest-environment-jsdom > jsdom > data-urls > abab@2.0.6: Use your platform's native atob() and btoa() methods instead
warning @pushkin-templates/exp-basic > jest-environment-jsdom > jsdom > domexception@4.0.0: Use your platform's native DOMException instead
See https://github.com/jestjs/jest/issues/14890. Seems like we could (a) not worry about it, since it's not currently breaking any tests, and upgrade jest-environment-jsdom
at a later date, (b) try to implement the fix suggested in the issue, or (c) have the CLI suppress the warnings. We can discuss today.
The package.json seems to missing a license which spits out an annoying warning
Can you show me what you're referring to? The package.json
for all the templates contains "license": "MIT"
.
It would be nice to have something that installed all 5 templates in one command
Will you make an issue and assign it to me? I think the best way is to leave install site
alone and then have an option for install experiment
that does all the available templates. We'll want this to work when there is more than one available site template.
I noticed all our dependabot security alerts relate to lock files rather than our direct dependencies in package.json. Here I just deleted and regenerated all lock files in the experiment templates (in
/api controllers
,/web page
, and/worker
for each exp template). This should resolve a bunch of our current dependabot security alerts.I've tested the templates locally and in a codespace, and everything looks normal. The experiments run and collect data as expected. The one thing I noticed when regenerating the lock files for the worker packages was I would get the following warnings:
It seems like we'll need to eventually do some dependency upgrades for pushkin-worker, but I'm not certain yet what specifically is needed. At any rate, it doesn't currently seem to affect anything.
@hunterschep @ayang21 -- For testing this, you'll want to use the dev CLI (
node <build path>
etc.) and install all templates from path.