Import all issues from zaru/webpush (will be fixed by this fork)

pushpad / web-push

Web Push library for Ruby (RFC8030) - A fork of zaru/webpush actively maintained by Pushpad with many improvements, bug fixes and updates.

MIT License

139 stars 13 forks source link

Import all issues from zaru/webpush (will be fixed by this fork) #1

Closed collimarco closed 1 year ago

collimarco commented 1 year ago

A list of all the issues and pull requests that are currently open on zaru/webpush and that we are going to fix with this fork:

Issues

Pull requests

collimarco commented 1 year ago

Notes:

~~Apple Push Service currently has a bug that cannot be fixed by this gem and you need to set urgency to high as a workaround~~
Windows Notification Service has a bug and currently return 406 instead of 429 for rate limiting (it's still in consideration if we should fix this strange behavior inside this gem or not)
We may consider, as an enhancement (not a bug), to catch some exceptions when the subscription fields (endpoint, keys, etc.) are malformed and raise some specific WebPush errors instead (see my comment for details)
~~We need to upgrade to OpenSSL v3 (see pull request)~~ Fixed: v3 now supports OpenSSL 3

collimarco commented 1 year ago

All the issues and pull requests that are not listed in the "Notes" are solved by this fork.

marckohlbrugge commented 1 year ago

All the issues and pull requests that are not listed in the "Notes" are solved by this fork.

Thanks for your work on this! Could you please clarify what you mean with "Notes" ?

E.g. I noticed the OpenSSL issue isn't resolved yet (pkeys are immutable on OpenSSL 3.0 (OpenSSL::PKey::PKeyError in v2.1.0), but the first message in thread makes it seem like it's completed already.

collimarco commented 1 year ago

@marckohlbrugge The notes in my comment above are issues imported from zaru/webpush that aren't solved yet by this fork. In any case we already use this gem in production, so they are not severe issues.

marckohlbrugge commented 1 year ago

@collimarco Sorry, I somehow totally missed that second comment with the notes.

I was able to manually pull in some of the changes from https://github.com/zaru/webpush/pull/106 into your branch and it seems to work 👍

collimarco commented 1 year ago

@marckohlbrugge The OpenSSL issue is now resolved. You can use this fork with OpenSSL v3.

francogp commented 1 year ago

I'm getting 406 Not Acceptable since yesterday, from microsoft edge notifications (I sent only 8).

collimarco commented 10 months ago

The Apple bug with "urgency" header is resolved now.