Possible recomposition issue

Hi, I'm having issue where UI isn't updating when I create new JetLimeItemsModel in response to some data being updated...I have made changes locally that seems to fix it but not sure if there are other ramifications of making that change.

So, firstly this is more or less what I have

val listState = rememberLazyListState()

val busInfoList by viewModel.busInfoList.collectAsState(emptyList())
val busStopList by viewModel.allBusStops.collectAsState(emptyList())

val jetLimeItemsModel by derivedStateOf {
        val jetItemList: MutableList<JetLimeItemsModel.JetLimeItem> = mutableStateListOf()

        if (busInfoList.isNotEmpty()) {
            val bus = busInfoList.find { it.vehicle_id == vechicleId }
            val nextStopRef = bus?.next_stop_ref

            val busList: List<String> = bus?.route ?: emptyList()
            busList.forEach { busStopRef ->
                val busStop = busStopList.find { it.stopRef == busStopRef }

                val busStopIndex = busList.indexOf(busStopRef)
                val nextBusStopIndex = busList.indexOf(nextStopRef)

                val jetLimeItemConfig = if (busStopRef == nextStopRef)
                    JetLimeItemConfig(iconAnimation = IconAnimation())
                else {
                    if (busStopIndex < nextBusStopIndex) {
                        JetLimeItemConfig(itemHeight = 80.dp, iconType = IconType.Checked)
                    } else {
                        JetLimeItemConfig(itemHeight = 80.dp, iconType = IconType.Empty)
                    }

                }

                jetItemList.add(
                    JetLimeItemsModel.JetLimeItem(
                        title = busStop?.shortName ?: "",
                        description = busStopRef,
                        jetLimeItemConfig = jetLimeItemConfig
                    )
                )
            }
        }
        JetLimeItemsModel(jetItemList)
    }

JetLimeView(
    jetLimeItemsModel = jetLimeItemsModel,
    jetLimeViewConfig = JetLimeViewConfig(lineType = LineType.Solid),
    listState = listState
)

I'm seeing that when nextStopRef changes (with resultant change to model) the UI is not updating (to show animation for that stop). Issue seems to be related to following code in JetLineView.

val jetLimeItem = remember { mutableStateOf(item) }

....

          JetLimeItemView(
            title = jetLimeItem.value.title,
            description = jetLimeItem.value.description,
            content = jetLimeItem.value.content,
            itemConfig = jetLimeItem.value.jetLimeItemConfig.apply { position = pos },
            viewConfig = jetLimeViewConfig,
            totalItems = jetLimeItemsModel.items.size
          )

If I replace jetLimeItem.value with just item above then recomposition seems to work correctly when the model value changes.

pushpalroy / JetLime

Possible recomposition issue #8