search

pushqrdx / vscode-inline-html

🎨 Adding Syntax Highlighting, Emmet, IntelliSense support for ES6 Template Strings in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=pushqrdx.inline-html
GNU General Public License v3.0
54 stars 15 forks source link

Unrelated executable present in the extension #30

Closed kidonng closed 1 year ago

kidonng commented 1 year ago

I noticed there is a file named croc taking up more than half the extension size:

$ du -sh ~/.vscode/extensions/pushqrdx.inline-html-*/* | sort -h | tail -n4
540K    /Users/kid/.vscode/extensions/pushqrdx.inline-html-0.3.5/docs
3.8M    /Users/kid/.vscode/extensions/pushqrdx.inline-html-0.3.5/node_modules
5.4M    /Users/kid/.vscode/extensions/pushqrdx.inline-html-0.3.5/croc
9.8M    total

Upon inspecting it seems to be an executable of https://github.com/schollz/croc:

$ file ~/.vscode/extensions/pushqrdx.inline-html-*/croc
/Users/kid/.vscode/extensions/pushqrdx.inline-html-0.3.5/croc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=6ad6eCjoCpDzAgT4fa1q/zgtYT6Jqz8Hudut1Z9pr/XktDKbBkBi9_EQ6gPETk/GnREkn9n1QHz_srmnqP8, stripped

There is no mention of the file in the repository, and its usage has nothing to do with the extension. I believe this is a mistake, and the extension should be republished with the executable removed.

pushqrdx commented 1 year ago

@kidonng for some reason vsce decided to include croc which is an application i frequently use in the extension bundle, thanks for notifying me about

pushqrdx commented 1 year ago

this was fixed a few versions back but I forgot to close this issue.