Variables inside strings not highlighted correctly?

pushqrdx / vscode-inline-html

🎨 Adding Syntax Highlighting, Emmet, IntelliSense support for ES6 Template Strings in Visual Studio Code.

https://marketplace.visualstudio.com/items?itemName=pushqrdx.inline-html

GNU General Public License v3.0

54 stars 15 forks source link

Variables inside strings not highlighted correctly? #39

Closed mrbelderock closed 1 year ago

mrbelderock commented 1 year ago

Perhaps I'm missing a way of escaping double quotes, below doesn't look quite right. es6-string-html highlights it more according to expectation.

Thanks for the extension otherwise - having emmet etc is great!

pushqrdx commented 1 year ago

@mrbelderock thanks for reporting this, I'll try to investigate it this weekend

alexrsmith-FS commented 1 year ago

Can confirm. I'm seeing the same issue. It's something specific to version 0.3.7. For me I'll just downgrade for now, which is very easy to do in vscode.

Wanted to also say thanks for this plugin. I find it very useful, my entire team uses it. Let me know if I can provide anymore info to help troubleshoot.

pushqrdx commented 1 year ago

@mrbelderock @alexrsmith-FS I have published a new version 0.3.8 that should fix this issue.

Thanks @alexrsmith-FS, pointing out it was a regression in 0.3.7 saved me a lot of time figuring out what caused it. I am glad you're finding inline html useful.

Please confirm that everything is back to working fine so I close this issue.

ryanzigler commented 1 year ago

@pushqrdx I just installed the update and I can confirm that the update fixed the issue for me!

Screen Shot 2023-04-10 at 10 09 35

Thanks for all your work on this extension!