search

pushrax / node-rcon

A generic RCON protocol client for node.js
MIT License
133 stars 31 forks source link

Fix truncating all final characters even if they weren't newlines #13

Closed inversion closed 8 years ago

pushrax commented 8 years ago

Which game are you seeing this be a problem in? I think the trailing newline is part of the spec (or what there is of it).

inversion commented 8 years ago

Hi @pushrax , it was a problem with Minecraft servers.

FlorianWendelborn commented 8 years ago

Could you please merge this? I'm really annoyed by that issue popping up when RCONing into my Minecraft server. I'm currently using this module to query online players and had to write a username matcher, which would fix the last character of the last username, because it's truncated.

pushrax commented 8 years ago

I'm still confused about this, but it's clearly an issue. Merging.