Fix TCP message too big

pushrax / node-rcon

A generic RCON protocol client for node.js

MIT License

133 stars 31 forks source link

Fix TCP message too big #16

Closed Darkhogg closed 8 years ago

Darkhogg commented 8 years ago

TCP messages should end with a double NUL byte: the body terminator, and an empty string terminator. A quadruple NUL byte was being added, which is too much, and at least one server implementation (Factorio) was failing because of that.

The UDP implementation is not affected by this change.

pushrax commented 8 years ago

Just looked at the spec – you're totally correct. Thanks!

Darkhogg commented 7 years ago

Is there any plans to release this (and possibly other fixes) to npm?

pushrax commented 7 years ago

Done, sorry about that huge delay.