search

pushrax / node-xdcc

Simple xdcc file transfers for node.js
21 stars 15 forks source link

Exception on Files >4GB #5

Open AresScorpio opened 8 years ago

AresScorpio commented 8 years ago

HI i had the issue that files larger then 4GB cannot be received. I wrote a patch if you are interessted i will provide you with that patch. This patch uses the same principle as mirc uses

pushrax commented 8 years ago

I think this is a limitation of the protocol itself – I can't find any documents explaining how to write the length back as anything other than a 4-byte int. Are you aware of an alternate response format?

AresScorpio commented 8 years ago

Yes, this is a limitation of the protocol. It was not designed to transfer files >4GB since they weren't able to store such large files back then. Never the less it is possible to transmit such large files using MIRC. I will provide a patch for this tomorrow - the patch will be compatible to MIRC, KVIRC and probably some other IRC Clients then you can decide whether you apply it or not.

pushrax commented 8 years ago

Great, that works for me.