pushrax / node-xdcc

Simple xdcc file transfers for node.js
21 stars 15 forks source link

Filename includes quotes incorrectly from DCC SEND #8

Closed rowaasr13 closed 3 years ago

rowaasr13 commented 4 years ago

DCC response parser includes quoting into returned filename, causing responses like DCC SEND "[Some] Particularry Long - 01 [Name] [ABCDEF01].bin" 2130706433 12345 1234567890 to save file literally named "[Some] Particularry Long - 01 [Name] [ABCDEF01].bin"

I see it discussed in pull #1, but never fixed. It causes extra set of quotes around names of named files that were not part of original file name which at very least breaks extension handling in visual shells and also causes a fatal error on any FS that doesn't supports quotes in filenames.

I've prepared a pull #9 that fixes it. It also includes a small manual test - it is not started automatically.