Update Segment helper to conform to segment spec

pushtell / react-ab-test

A/B testing React components and debug tools. Isomorphic with a simple, universal interface. Well documented and lightweight. Tested in popular browsers and Node.js. Includes helpers for Mixpanel and Segment.com.

MIT License

752 stars 112 forks source link

Update Segment helper to conform to segment spec #19

Closed buob closed 7 years ago

buob commented 7 years ago

Match Experiment Viewed spec per ab-testing docs https://segment.com/docs/spec/ab-testing/
Use past tense verbiage for Experiment win https://segment.com/academy/collecting-data/naming-conventions-for-clean-data/
Update docs to show window.analytics instead of window.segment

Close #15

peterpme commented 7 years ago

:wave: anything I can do to help move this along?

wehriam commented 7 years ago

@peterpme just made you a collaborator. Let me know after you've reviewed this and run through the tests, I'll issue a new npm release.

Unfortunately I'm swamped these days and don't have much time to contribute. Apologies for any delays!

peterpme commented 7 years ago

No worries. Thanks a ton @wehriam! I'll help push these along :smile:

peterpme commented 7 years ago

Merging this in. Will update window.analytics myself