Fix/react 15 5 - Githubissues

pushtell / react-ab-test

A/B testing React components and debug tools. Isomorphic with a simple, universal interface. Well documented and lightweight. Tested in popular browsers and Node.js. Includes helpers for Mixpanel and Segment.com.

MIT License

752 stars 112 forks source link

Fix/react 15 5 #22

Closed Anomen closed 7 years ago

Anomen commented 7 years ago

For support of React 15.5:

Changed deprecated React.PropTypes to use prop-types
Changed deprecated React.createClass to ES6 class

peterpme commented 7 years ago

Wow @Anomen thank you so much for this awesome PR! I will help you push this along and merge it in :smile:

I haven't had a chance to test it myself locally - do all the tests continue to pass?

Thanks again!

Anomen commented 7 years ago

Hey @peterpme :) Yes, all the tests pass. The only thing that could be improved is to also change React.createClass inside the tests themselves, because it create a warning when running them (which does not make them fail, though).

I can try to fix them in the coming days ;)

diondirza commented 7 years ago

when will this PR be merged? any progress so far?

peterpme commented 7 years ago

@diondirza we can merge it in, just want to take care of the standalone.min.js conflict :)

exwar commented 7 years ago

@Anomen Any chance you can have a look at these conflicts and get this merged?