search

pushtell / react-ab-test

A/B testing React components and debug tools. Isomorphic with a simple, universal interface. Well documented and lightweight. Tested in popular browsers and Node.js. Includes helpers for Mixpanel and Segment.com.
MIT License
752 stars 112 forks source link

[Debugger] Accessing createClass via the main React package is deprecated #39

Open ksloan opened 7 years ago

ksloan commented 7 years ago

It looks like this was fixed in #32, but the debugger was never fixed.

Specifically it's complaining about this line https://github.com/pushtell/react-ab-test/blob/master/lib/debugger.js#L97

ie. https://github.com/pushtell/react-ab-test/blob/master/src/debugger.jsx#L81

ksloan commented 7 years ago

I realize you're working on this, but it's crashing React 16.0 now.

okovpashko commented 7 years ago

@ksloan it's an expected behavior. Deprecation warnings in React v15.5 and v15.6 become errors in React v16. I've created a PR, but it's waiting to be checked and merged by the contributors.

@peterpme @wehriam could you please check the PR and merge it?

kjs3 commented 6 years ago

@peterpme, @wehriam: Is there an issue with @okovpashko's PR?

philals commented 6 years ago

FYI - moretti has forked waiting pending PRs/new maintainers(?): https://github.com/marvelapp/react-ab-test

Here's another thread: https://github.com/pushtell/react-ab-test/pull/42