search

pushtell / react-ab-test

A/B testing React components and debug tools. Isomorphic with a simple, universal interface. Well documented and lightweight. Tested in popular browsers and Node.js. Includes helpers for Mixpanel and Segment.com.
MIT License
752 stars 112 forks source link

emitter.getActiveVariant() called without parameter #6

Closed bigmac44 closed 8 years ago

bigmac44 commented 8 years ago

Line 48 of Experiment.jsx

const activeValue = emitter.getActiveVariant();

The getActiveVariant method takes an experiment name as a parameter. Without supplying the experiment name, this method will never return anything. I don't believe this is the intended behavior of the line.

wehriam commented 8 years ago

Thanks again for the report and review of the code. Please let me know if you encounter any additional issues.