fix: don't change placeholder when focused

pushtell / react-bootstrap-date-picker

React-Bootstrap based date picker.

MIT License

347 stars 195 forks source link

Closed mchirkin closed 7 years ago

mchirkin commented 7 years ago

Fix #83

wehriam commented 7 years ago

Some people use placeholders that are not associated with the date format, for example "Birthday."

This PR would not show the date format hinting for those users, and thus removes functionality.

I can't accept this as-is, would you like to instead add a focusedPlaceholder property?

wehriam commented 7 years ago

Actually, it looks like this out of date PR implements this functionality: https://github.com/pushtell/react-bootstrap-date-picker/pull/65

You may want to fork that work bring it up to date with this repo.

mchirkin commented 7 years ago

I added a focusedPlaceholder prop. Please review changes.

wehriam commented 7 years ago

Hi @mchirkin - thanks for the PR! Please review the conflicts when you have a chance.