search

pushtell / react-bootstrap-date-picker

React-Bootstrap based date picker.
MIT License
346 stars 195 forks source link

Incompatible with react-bootstrap 0.31 #122

Open uksparky opened 7 years ago

uksparky commented 7 years ago

Expected Behavior

No NPM error or warning when using react-bootstrap 0.31

Current Behavior

npm ERR! peerinvalid The package react-bootstrap does not satisfy its siblings' peerDependencies requirements! npm ERR! peerinvalid Peer react-bootstrap-date-picker@5.0.1 wants react-bootstrap@^0.30.8

Possible Solution

Steps to Reproduce (for bugs)

  1. Create package.json with entries:

    "react-bootstrap": "0.31.0", "react-bootstrap-date-picker": "^5.0.1",

  2. Run npm install

Context

Breaks npm package management. Have to force use of react-bootstrap 0.30.8

Your Environment

johhansantana commented 7 years ago

Getting an error TypeError: isoString.slice is not a function

    "react-bootstrap": "0.30.8",
    "react-bootstrap-date-picker": "^5.0.1",
SeanWangDev commented 7 years ago

it does not break in my case. 5.0.1 on react-bootstrap 0.31.0. Though it gives a warning.

npm WARN react-bootstrap-date-picker@5.0.1 requires a peer of react-bootstrap@^0.30.8 but none was installed.

NicolasPinzon commented 6 years ago

This happened to me because I had a function as a value for the value property. I changed the name of the property from value to ref and it compiled.

My dependencies: "react-bootstrap": "^0.31.5", "react-bootstrap-date-picker": "github:pushtell/react-bootstrap-date-picker#f622dc8872dd180324ba5d3c295d009848f5814b",

ashish2rathi commented 4 years ago

I am also facing the same issue, but I feel there is no update going to come on 'react-bootstrap-date-picker' as this already 3 year old issue. Better to you some another package.